Skip to content

feat: add buf cli #510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 23, 2025
Merged

feat: add buf cli #510

merged 2 commits into from
Sep 23, 2025

Conversation

@amammay
Copy link
Contributor

@amammay amammay commented Sep 16, 2025

Hello, was looking to see if you are open to having the buf cli available within the project. I tried doing this years ago with a similar project namely/docker-protoc#250 and i think that project(namely/docker-protoc) has been abandoned.

The usage of this could be like so

docker run -it -v $PWD:/tmp --entrypoint buf  moby-dangling@sha256:806d8e05fbb7f1d6f8db33cd822eaee32d40931ef30e6138a901c7c909b14fdf generate --template /tmp/buf.gen.yaml -o /tmp /tmp
version: v2
clean: true
managed:
  enabled: true
plugins:
  - local: protoc-gen-go
    out: gen/proto

Which would allow for using the buf cli to orchestrate generation against local plugins.

Thanks for the consideration!

rvolosatovs
rvolosatovs approved these changes Sep 17, 2025
View reviewed changes
Copy link
Owner

@rvolosatovs rvolosatovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

I've never used buf myself, but keep hearing good things about it. I think I understand the use case and it makes sense to me - this looks like a good addition.

@strophy what do you think?

@strophy
Copy link
Collaborator

strophy commented Sep 21, 2025

I also haven't used it, but understand it makes a useful addition to the project!

I wonder if it makes more sense to install it with apk add buf instead, since then we get the benefits of the Alpine package maintainer, shell completions, etc.?

@amammay
Copy link
Contributor Author

amammay commented Sep 22, 2025

I also haven't used it, but understand it makes a useful addition to the project!

I wonder if it makes more sense to install it with apk add buf instead, since then we get the benefits of the Alpine package maintainer, shell completions, etc.?

So i was going based off https://buf.build/docs/cli/installation/#github. Which i figured would be a good source of truth. I can look into the apk repo further if wanted. Just dont think the apk listing is managed by the buff team i think (from a quick cursory look)

@strophy
Copy link
Collaborator

strophy commented Sep 23, 2025

I was thinking buf might be built with gnulibc instead of musl, but after testing I have verified the binary seems to work as expected. Looks good to me, thanks for your contribution and let's merge this useful tool in 🚀

@strophy strophy merged commit 9d90803 into rvolosatovs:main Sep 23, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rvolosatovs rvolosatovs rvolosatovs approved these changes

@strophy strophy strophy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@amammay @strophy @rvolosatovs